added 2 new options to make ParseXLSX more efficient with Large Multi-tab Workbooks #98
Open
cboleary wants to merge 4 commits intodoy:masterfrom
Open
added 2 new options to make ParseXLSX more efficient with Large Multi-tab Workbooks #98cboleary wants to merge 4 commits intodoy:masterfrom
cboleary wants to merge 4 commits intodoy:masterfrom
Conversation
--just_find_sheet_names If just_find_sheet_names is set, the code will quickly return the worksheetInfo without parsing each worksheet and --sheet_filter comma separated string of worksheet names to parse if sheet_filter is not set, the module operates as it did, parsing EVERY worksheet in the workbook if its set, the module will only parse the worksheets listed which can be way more efficient
…tested) I needed to return a shell of a WorkSheet with an empty list for the Cells Attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix a performance issue with the way ParseXLSX handles large spreadsheets.
If you use the ReadData method, it parses every worksheet in the workbook and this can consume alot of time
especially if you just want to find out the worksheet tab names
Added option:
--just_find_sheet_names
If just_find_sheet_names is set, the code will quickly return the worksheetInfo without parsing each worksheet
and
--sheet_filter comma separated string of worksheet names to parse
if sheet_filter is not set, the module operates as it did, parsing EVERY worksheet in the workbook
if its set, the module will only parse the worksheets listed which can be way more efficient