feat(@dpc-sdp/ripple-ui-forms): update how active step is determined#1363
Open
lambry wants to merge 12 commits intofeature/steps-controlfrom
Open
feat(@dpc-sdp/ripple-ui-forms): update how active step is determined#1363lambry wants to merge 12 commits intofeature/steps-controlfrom
lambry wants to merge 12 commits intofeature/steps-controlfrom
Conversation
* feat(@dpc-sdp/ripple-ui-form): file component * feat(@dpc-sdp/ripple-ui-form): update tests and stories * feat(@dpc-sdp/ripple-ui-form): add class, update placeholder * feat(@dpc-sdp/ripple-ui-form): update allowTypes * feat(@dpc-sdp/ripple-ui-form): update disabled states for file field * chore(@dpc-sdp/ripple-ui-form): update form story * chore(@dpc-sdp/ripple-ui-form): minor width update for file field * test(@dpc-sdp/ripple-ui-form): add extra onChange test * feat(@dpc-sdp/ripple-ui-form): design feedback
* feat(@dpc-sdp/ripple-ui-core): updated design of vertical nav component * style(@dpc-sdp/ripple-ui-core): removed unused types
#1360) * refactor(@dpc-sdp/ripple-ui-form): add fieldId and formId to handleUpload options * chore(@dpc-sdp/ripple-ui-forms): change spin speed, add missing focus class * chore(@dpc-sdp/ripple-ui-forms): update error message wording
* feat(@dpc-sdp/ripple-ui-forms): initial work for the autocomplete form input * feat(@dpc-sdp/ripple-ui-forms): added action button to autocomplete input * fix(@dpc-sdp/ripple-ui-forms): added missing autocomplete prop * feat(@dpc-sdp/ripple-ui-forms): remove unused props add disabled styles * feat(@dpc-sdp/ripple-ui-forms): autocomplete updates, adding tests, update stories hide no results message while search is in progress, class updates --------- Co-authored-by: David Featherston <david.featherstone@dpc.vic.gov.au>
add option to exclude step from review, auto run the main step change validation
fix icon spacing, focus display, and rotation, remove .only so all tests run, remove getParentChain so active item is set in ripple framework
* chore(@dpc-sdp/ripple-ui-maps): fix lint warning * chore: file and package cleanup * test: remove .only in tests and add lint check for .only * ci: run alpha release on workflow dispatch and only publish to chromatic on main and PRs * revert: chromatic publish condition
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
Hey @dylankelly, this (1253ce7) "fixed" the typecript errors around the |
…, show back for child steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-1587
What I did
How to test
Checklist
For all PR's
For new UI components only
emitRplEvent