Skip to content

feat: support passing login query string to oauth authorize redirect #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scarbeau wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: support passing login query string to oauth authorize redirect #2222

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebd0aa0
feat: support optionally passing login query string to oauth authoriz…
scarbeau Mar 21, 2024
4b7040e
Merge branch 'master' into feat/preserve-query-string-on-oauth-login-…
scarbeau Mar 18, 2025
6469237
Merge branch 'dpgaspar:master' into feat/preserve-query-string-on-oau…
scarbeau May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions flask_appbuilder/security/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,11 @@ def login(self, provider: Optional[str] = None) -> WerkzeugResponse:
request.args.to_dict(flat=False), random_state, algorithm="HS256"
)
session["oauth_state"] = random_state

params = {}
if current_app.config.get("AUTH_OAUTH_PRESERVE_LOGIN_QUERY", False):
params = request.args

try:
if provider == "twitter":
return self.appbuilder.sm.oauth_remotes[provider].authorize_redirect(
Expand All @@ -737,6 +742,7 @@ def login(self, provider: Optional[str] = None) -> WerkzeugResponse:
".oauth_authorized", provider=provider, _external=True
),
state=state.decode("ascii") if isinstance(state, bytes) else state,
**params,
)
except Exception as e:
log.error("Error on OAuth authorize: %s", e)
Expand Down