feat: Make password hashing parameters configurable#2332
Merged
dpgaspar merged 3 commits intodpgaspar:masterfrom Apr 17, 2025
Merged
feat: Make password hashing parameters configurable#2332dpgaspar merged 3 commits intodpgaspar:masterfrom
dpgaspar merged 3 commits intodpgaspar:masterfrom
Conversation
denis-ismailaj
force-pushed
the
configurable-pass-hashing
branch
from
beab5b5 to
78161de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2332 +/- ##
==========================================
+ Coverage 73.81% 74.81% +0.99%
==========================================
Files 72 72
Lines 8754 9160 +406
==========================================
+ Hits 6462 6853 +391
- Misses 2292 2307 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 17, 2025
The dpgaspar/Flask-AppBuilder#2332 introduced new configuration parameter, where it defaulted hash algorithm for passwords to "scrypt". However with our (old) version of Werkzeug, scrypt is not supported and default should be set to "pbkdf2:sha256" Fixes: 51854
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Jun 17, 2025
The dpgaspar/Flask-AppBuilder#2332 introduced new configuration parameter, where it defaulted hash algorithm for passwords to "scrypt". However with our (old) version of Werkzeug, scrypt is not supported and default should be set to "pbkdf2:sha256" Fixes: 51854
potiuk
added a commit
to potiuk/Flask-AppBuilder
that referenced
this pull request
Jun 17, 2025
Follow up after dpgaspar#2306. Later configuration was added in dpgaspar#2332 that added default configuration for hash method and also there scrypt was set as default, however Werkzeug < 3.0.0 does not support it. This PR retrieves the default method properly, depending on installed Werkzeug version.
6 tasks
potiuk
added a commit
to potiuk/Flask-AppBuilder
that referenced
this pull request
Jun 17, 2025
Follow up after dpgaspar#2306. Later configuration was added in dpgaspar#2332 that added default configuration for hash method and also there scrypt was set as default, however Werkzeug < 3.0.0 does not support it. This PR retrieves the default method properly, depending on installed Werkzeug version.
potiuk
added a commit
to potiuk/Flask-AppBuilder
that referenced
this pull request
Jun 17, 2025
Follow up after dpgaspar#2306. Later configuration was added in dpgaspar#2332 that added default configuration for hash method and also there scrypt was set as default, however Werkzeug < 3.0.0 does not support it. This PR retrieves the default method properly, depending on installed Werkzeug version.
potiuk
added a commit
to potiuk/Flask-AppBuilder
that referenced
this pull request
Jun 17, 2025
Follow up after dpgaspar#2306. Later configuration was added in dpgaspar#2332 that added default configuration for hash method and also there scrypt was set as default, however Werkzeug < 3.0.0 does not support it. This PR retrieves the default method properly, depending on installed Werkzeug version.
potiuk
added a commit
to potiuk/Flask-AppBuilder
that referenced
this pull request
Jun 17, 2025
Follow up after dpgaspar#2306. Later configuration was added in dpgaspar#2332 that added default configuration for hash method and also there scrypt was set as default, however Werkzeug < 3.0.0 does not support it. This PR retrieves the default method properly, depending on installed Werkzeug version.
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
…51858) The dpgaspar/Flask-AppBuilder#2332 introduced new configuration parameter, where it defaulted hash algorithm for passwords to "scrypt". However with our (old) version of Werkzeug, scrypt is not supported and default should be set to "pbkdf2:sha256" Fixes: 51854
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 23, 2025
The dpgaspar/Flask-AppBuilder#2332 introduced new configuration parameter, where it defaulted hash algorithm for passwords to "scrypt". However with our (old) version of Werkzeug, scrypt is not supported and default should be set to "pbkdf2:sha256" Fixes: 51854 GitOrigin-RevId: 7cecc66069a2588dfaba95a030f09076552c4c68
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 28, 2026
The dpgaspar/Flask-AppBuilder#2332 introduced new configuration parameter, where it defaulted hash algorithm for passwords to "scrypt". However with our (old) version of Werkzeug, scrypt is not supported and default should be set to "pbkdf2:sha256" Fixes: 51854 GitOrigin-RevId: 7cecc66069a2588dfaba95a030f09076552c4c68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of PR #2234.
It should be noted that apart from the compliance reasons mentioned in the original PR, this change
is also necessary for compatibility with Python <=3.9 on macOS where
hashlib.scryptis not available.Two configuration options have been added:
FAB_PASSWORD_HASH_METHODandFAB_PASSWORD_HASH_SALT_LENGTH.While
FAB_PASSWORD_HASH_SALT_LENGTHis not strictly required for the reasons mentioned above,I included it as there may be use cases where configuring both is needed.
ADDITIONAL INFORMATION