fix: update user.changed_on when roles are modified#2423
Merged
dpgaspar merged 3 commits intodpgaspar:masterfrom Feb 3, 2026
Merged
fix: update user.changed_on when roles are modified#2423dpgaspar merged 3 commits intodpgaspar:masterfrom
dpgaspar merged 3 commits intodpgaspar:masterfrom
Conversation
Alok-kumar-priyadarshi
changed the title
dpgaspar
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the User.changed_on field is not updated when user roles are modified.
Role changes update the user.roles relationship, but SQLAlchemy does not trigger onupdate for relationship-only changes. As a result, the user audit timestamp becomes stale.
The fix explicitly updates changed_on in SecurityManager.update_user(), ensuring user audit metadata stays accurate when roles or groups change.
A small regression test is included.