refactor: switch to hooks for linting#2447
Open
Dev-iL wants to merge 2 commits intodpgaspar:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the legacy linting toolchain (black, flake8, flake8-import-order) with ruff and switch CI from running individual lint commands to prek (a Rust-based pre-commit runner) executing hooks defined in
.pre-commit-config.yaml.What changed:
ruff check, replacing flake8 + flake8-import-order) and formatting (ruff format, replacing black). Mypy is kept as-is since ruff does not cover type checking.pip install+ manual invocation approach in CI with a singleprek run --all-filesstep..pre-commit-config.yamlwith ruff and mypy hooks.[tool.ruff]configuration inpyproject.toml, matching the previous flake8 settings (line-length 90, same excludes, google-style import ordering via isort rules).[flake8]section fromsetup.cfg, removed[testenv:flake8]and[testenv:black]fromtox.ini.requirements/dev.in: dropped black, flake8, flake8-import-order; added ruff and prek.Note regarding mypy
The 3 failing modules (
validators,models.sqla,models.sqla.interface) now haveignore_errors = truewith TODO comments. The old CI never actually checked them due to the broken glob, so this matches the prior behavior. The type errors can be fixed in a follow-up.ADDITIONAL INFORMATION