Skip to content

Release coordinator lock before calling maybe_leave_group #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
Feb 6, 2025
Merged

Release coordinator lock before calling maybe_leave_group #2460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions kafka/coordinator/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,11 @@ def _run_once(self):
# foreground thread has stalled in between calls to
# poll(), so we explicitly leave the group.
log.warning('Heartbeat poll expired, leaving group')
### XXX
# maybe_leave_group acquires client + coordinator lock;
# if we hold coordinator lock before calling, we risk deadlock
# release() is safe here because this is the last code in the current context
self.coordinator._lock.release()
self.coordinator.maybe_leave_group()

elif not self.coordinator.heartbeat.should_heartbeat():
Expand Down