Skip to content

Retain unrecognized broker response error codes with dynamic error class #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
Feb 15, 2025
Merged

Retain unrecognized broker response error codes with dynamic error class #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def update_metadata(self, metadata):
"""
# In the common case where we ask for a single topic and get back an
# error, we should fail the future
if len(metadata.topics) == 1 and metadata.topics[0][0] != 0:
if len(metadata.topics) == 1 and metadata.topics[0][0] != Errors.NoError.errno:
error_code, topic = metadata.topics[0][:2]
error = Errors.for_code(error_code)(topic)
return self.failed_update(error)
Expand Down
18 changes: 9 additions & 9 deletions kafka/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,15 +512,15 @@ def _iter_broker_errors():


def for_code(error_code):
return kafka_errors.get(error_code, UnknownError)


def check_error(response):
if isinstance(response, Exception):
raise response
if response.error:
error_class = kafka_errors.get(response.error, UnknownError)
raise error_class(response)
if error_code in kafka_errors:
return kafka_errors[error_code]
else:
# The broker error code was not found in our list. This can happen when connecting
# to a newer broker (with new error codes), or simply because our error list is
# not complete.
#
# To avoid dropping the error code, create a dynamic error class w/ errno override.
return type('UnrecognizedBrokerError', (UnknownError,), {'errno': error_code})


RETRY_BACKOFF_ERROR_TYPES = (
Expand Down