Skip to content

REF: switch to deque.copy() for Python 3 compatibility #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yranjan06 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

REF: switch to deque.copy() for Python 3 compatibility #2712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions kafka/consumer/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import collections
import copy
import itertools
import logging
import sys
Expand Down Expand Up @@ -611,8 +610,7 @@ def _fetchable_partitions(self):
fetchable = self._subscriptions.fetchable_partitions()
# do not fetch a partition if we have a pending fetch response to process
# use copy.copy to avoid runtimeerror on mutation from different thread
# TODO: switch to deque.copy() with py3
discard = {fetch.topic_partition for fetch in copy.copy(self._completed_fetches)}
discard = {fetch.topic_partition for fetch in self._completed_fetches.copy()}
current = self._next_partition_records
if current:
discard.add(current.topic_partition)
Expand Down