-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fixed couple of "leaks" when gc is disabled #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
532c498
8cba224
8d26f5c
8b27802
0b82c46
95dd511
9e4913f
ded0998
d9fce4a
f1df0cd
067e632
db11ab4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,7 +70,9 @@ def __len__(self): | |
| else: | ||
| # 64-bit | ||
| MAXSIZE = int((1 << 63) - 1) | ||
| del X | ||
|
|
||
| # Don't del it here, cause with gc disabled this "leaks" to garbage | ||
| # del X | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this one is a vendored library, and I really would prefer fixing upstream. otherwise I'm likely to forget and overwrite when I import a newer version. Have you checked if this is fixed already in six?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Upstream doesn't have this fix, but I've filed a pull request: benjaminp/six#176 |
||
|
|
||
|
|
||
| def _add_doc(func, doc): | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same re: vendored library. Can you check with upstream version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request to vendored library: berkerpeksag/selectors34#7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream merged pull request.