Skip to content

Enhancement #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kangshugang wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enhancement #33

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0bb6b3b
fix issue 14
kangshugang Oct 11, 2017
ce65832
fix a break point toggle issue.
kangshugang Oct 11, 2017
761790f
make some enhancements
kangshugang Oct 11, 2017
06a0576
enhance the debuger by adding variables and call stack
kangshugang Oct 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/python-debugger-view.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ class PythonDebuggerView extends View
@stopApp() if @backendDebugger
@debuggedFileArgs = @getInputArguments()
console.log @debuggedFileArgs
@debuggedFileName = @getCurrentFilePath()
Copy link
Owner

@dpo dpo Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the following if be removed and replaced with a call to askForPaths() then?

Copy link
Contributor Author

@kangshugang kangshugang Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is adding the last line, which set the file to debug as the current active file.

The if is to check whether we need to stop the debugging (if the debugger is already running). This is the original code. It has nothing to do with the change.

Copy link
Owner

@dpo dpo Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm saying is that, because you set debuggedFileName, the next if will never be active (pathsNotSet() will always return false).

Copy link
Contributor Author

@kangshugang kangshugang Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misunderstood your comment.

Copy link
Contributor Author

@kangshugang kangshugang Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is up to you incorporate the changes. I am happy, as long as it works. :-)

if @pathsNotSet()
@askForPaths()
return
Expand Down