Limit PFC WD Detection time to maximum value of 1000[ms]#16
Closed
Limit PFC WD Detection time to maximum value of 1000[ms]#16
Conversation
stephenxs
reviewed
Dec 11, 2025
stephenxs
left a comment
There was a problem hiding this comment.
LGTM but I think we still need to confirm the performance on tigon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
PFC WD Detection time is defined by the following calculation:
DEFAULT_POLL_INTERVAL * multiply
where:
There is an allowed range for this value which is between 100..3000 [ms].
For system with more than 448 ports, we will violate this range.
In addition, there is no meaning to have detection time of more than 1000[ms], hence, this change limit the maximum detection time for PFC WD to 1000[ms]
How I did it
Calculate PFC WD Detection time, if it become bigger than 1000[ms], set it to 1000[ms]
How to verify it
Run PFC WD Tests on several platforms
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)