escalator: Fix escalators in north-point mall#37
Merged
Conversation
JayFoxRox
commented
Feb 7, 2019
JayFoxRox
commented
Feb 7, 2019
JayFoxRox
commented
Feb 7, 2019
Owner
|
Lines should end with |
JayFoxRox
force-pushed
the
escalator-fix
branch
2 times, most recently
from
af9628a to
be2791b
Compare
JayFoxRox
force-pushed
the
escalator-fix
branch
from
be2791b to
71d6959
Compare
dracc
reviewed
Feb 25, 2019
| create_escalator_fix(world, p + Vector(d, 0.0, 0.0), a, count); | ||
| } | ||
|
|
||
| function create_double_stair_up_down_fix(world, p, a, d) { |
Collaborator
Author
There was a problem hiding this comment.
Meh.. I'll force push to master to fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #32, see header in file for what this does / how it works.
Code could be nicer, but this will do for now.
We could also make the stairs invisible, but I think this implementation also nicely hides the stairs appearing / disappearing.