ghostcars: /ghost sets players driven vehicle as ghost

[dracc]

Closes #43

Idea is to set cars as ghosts. Undocumented feature but with a bit of imagination you can interpret the function as "disable collisions".

I have yet to test this code.

[JayFoxRox]

Wouldn't this also happen if a passenger left your car?

[dracc]

Hmm, yeah, probably. I'll add a check for vehicle.Driver - should be == null if the driver is the one leaving. Or == player.ID.

[dracc]

Resolved?

[JayFoxRox]

• We should also find a way to mark ghost cars (if it's player controllable), possibly by giving them a unique color or something (unfortunately there's no Vehicle.Alpha). Until this happens, it should probably not be done, because it leads to unpredictable behaviour.

• I believe I'd rather have this as a command (than a keybind - see Create bind script #15 ).

• It should probably be default-off, as user-controlled ghosting should be a last resort (to avoid cars parked in a way, or congestion).

• We'll have to make sure this never runs out of synchronization to avoid unpredictable behaviour:

  • What happens if the script forces the player into a vehicle?

  • What happens if a player joins a game?

  • What happens if a player leaves the game?

  • ...

• Do ghosts still have collisions with script-objects?

[dracc]

* We should also find a way to mark ghost cars (if it's player controllable), possibly by giving them a unique color or something (unfortunately there's no `Vehicle.Alpha`). Until this happens, it should probably not be done, because it leads to unpredictable behaviour.

Place them in player.UniqueWorld?

* I believe I'd rather have this as a command (than a keybind - see #15 ).

Fixed!

* It should probably be default-off, as user-controlled ghosting should be a last resort (to avoid cars parked in a way, or congestion).

I believe it already is.
https://github.com/JayFoxRox/modular-vc-mp-server/pull/44/files#diff-a7f6143f8376f658de3dfb515520e4aeR3

* We'll have to make sure this never runs out of synchronization to avoid unpredictable behaviour:      
  * What happens if the script forces the player into a vehicle?

I need to test this, my theory is onPlayerEnterVehicle() is triggered.

  * What happens if a player joins a game?

Requires testing but I don't see why this would be different than usual behavior (i.e. cars are visible, have their current traits such as color1/color2, model and so on)

  * What happens if a player leaves the game?

Should probably add a check for player.Vehicle != null in onPlayerPart(). Fixed!

* Do ghosts still have collisions with script-objects?

It does not deactivate object collision.