fix(fcoe-uefi): exit early on empty vlan #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
modules
mwilck
approved these changes
Jul 14, 2025
LaszloGombos
previously approved these changes
Jul 14, 2025
bdrung
reviewed
Jul 15, 2025
Exit early in case get_fcoe_boot_vlan exits with error or just an empty string, instead of producing invalid config entry.
|
closing temporary to reduce review queue. |
bdrung
approved these changes
Jul 29, 2025
LaszloGombos
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Exit early in case
get_fcoe_boot_vlanexits with error or just an empty string, instead of producing invalid config entry.Found this PR at dracutdevs/dracut#2379 from @pvalena .
CC @pvalena @mwilck @aafeijoo-suse @lnykryn @LaszloGombos
Checklist