Skip to content

Conversation

@gcelanji
Copy link
Contributor

@gcelanji gcelanji commented Dec 10, 2025

Summary

Currently, even though Liquid works as expected in Word filters and other contexts, it cannot be displayed properly in the Issues/Evidence tables.

Leverage the existing liquid-async and preview flow to render liquid content for issues and evidence field tables.

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

Check List

  • Added a CHANGELOG entry
  • Commit message has a detailed description of what changed and why.

else
[evidence.fields.fetch(column, ''), markup(evidence.fields.fetch(column, ''))]
liquid_content = evidence.fields.fetch(column, '')
preview_path = preview_project_issue_evidence_path(current_project, @issue, evidence)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd set this in the controller like we do with @form_preview_path

Copy link
Contributor Author

@gcelanji gcelanji Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the index action only handles the collection, the controller cannot access a specific evidence instance variable to set the preview_path. Therefore, we must either add logic to iterate over all evidence records in the controller index action, or use the Evidence.new approach to generate a reusable path template for JS to update the path with the correct ID.

In this specific context, neither of those two options is worth the added complexity or performance drop. The simplest and most efficient solution is to keep the path generation in the view partial's loop, where the evidence is availiable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants