Add support for wasm-bindgen's browser-only hint#1403
Open
nightspc wants to merge 1 commit intodrager:masterfrom
Open
Add support for wasm-bindgen's browser-only hint#1403nightspc wants to merge 1 commit intodrager:masterfrom
nightspc wants to merge 1 commit intodrager:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not fully address #689 as this only works in very specific environments (usually requires wasm is inlined as base64 by a bundler plugin).
Code that runs in a Worklet/AudioWorklet context only has access to a limited subset of browser APIs. To allow running under these restrictions, wasm-bindgen provides the
--browserflag which alters the generated JS code for these environments.Currently, there is no way to tell
wasm-packto use this flag when building. This PR adds support for forwarding this flag towasm-bindgen.rustfmtinstalledcargo fmton the code base before submitting