fix: Fix the parse error when package.json is generated by wasm-bindgen#1450
Open
mohebifar wants to merge 1 commit intodrager:masterfrom
Open
fix: Fix the parse error when package.json is generated by wasm-bindgen#1450mohebifar wants to merge 1 commit intodrager:masterfrom
mohebifar wants to merge 1 commit intodrager:masterfrom
Conversation
Introduces WasmBindgenPackageJson for deserializing package.json generated by wasm-bindgen
bd3caf3 to
4c97177
Compare
Author
|
Bumping this PR. Any blockers for merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building one of my projects, I kept running into this issue:
Error:
Root Cause
The issue originates in the
step_create_jsonand thefn write_package_json. During the build process, the followingpackage.jsonwas generated bywasm-bindgen:{ "dependencies": { "web-tree-sitter-sg": "0.22.2" } }While this
package.jsonis valid, the code incorrectly attempted to parse the entire file as aHashMap<String, String>. This led to a failure when merging dependencies because thedependenciesfield itself is a map, not a string.Fix
This PR updates the parsing logic to correctly handle the
package.jsonstructure.Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨