-
Notifications
You must be signed in to change notification settings - Fork 98
feat(hpa): Add horizontal pod autoscaling for DragonFly instances #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smunukutla-mycarrier
wants to merge
15
commits into
dragonflydb:main
Choose a base branch
from
smunukutla-mycarrier:smunukutla-autoscale-dragonflydb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,447
−11,400
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
35ca48d
add horizontal autoscaler
smunukutla-mycarrier 0c04c77
Merge branch 'dragonflydb:main' into smunukutla-autoscale-dragonflydb
smunukutla-mycarrier 4a5874e
WIP: added e2e tests for hpa and fixed replica control issue
smunukutla-mycarrier 591104e
fix hpa deletion issue
smunukutla-mycarrier 9f14841
remove unnecessary tests
smunukutla-mycarrier fde45ad
fix bug with transition between autoscaler to just using replica, add…
smunukutla-mycarrier dd177ea
cleanup makefile
smunukutla-mycarrier 4f745a4
Merge branch 'main' into smunukutla-autoscale-dragonflydb
smunukutla-mycarrier 5958933
Merge branch 'main' into smunukutla-autoscale-dragonflydb
smunukutla-mycarrier 7459a3b
fix: set crd:MaxDescLen to 0 to avoid annotation max length issue
smunukutla-mycarrier 9ed5a35
Merge branch 'main' into smunukutla-autoscale-dragonflydb
smunukutla-mycarrier a3f278f
fix merge issue
smunukutla-mycarrier 84d61d7
updated manifests - removed descriptions to avoid max length issue
smunukutla-mycarrier 36fda64
refactor: remove targetMemoryUtilizationPercentage from AutoscalerSpe…
smunukutla-mycarrier 09a8ac4
Merge branch 'main' into smunukutla-autoscale-dragonflydb
Abhra303 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that adding replicas can only increase your read throughput
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The feature to scale horizontally is to accommodate cache reads as traffic increases - reducing load on master and existing replicas. It would be great to handle that automatically rather than updating replicas manually.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashotland please review and run the workflow when you get a chance. The tests passed for me locally.