feat(operator): Add support for PVC retention policy #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurence Robinson <[email protected]>
|
Hi @robinsla-deshaw, e2e tests are failing, can you please fix those first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #340
persistentVolumeClaimRetentionPolicyfield using the struct from appsv1GenerateDragonflyResourcefunction to set it in the StatefulSet if presentI've added tests but I've not used this testing harness before so sorry if I've not done it right/put it in the wrong place.
I've tested locally and things work as I'd expect:
This would only work on Kubernetes clusters running 1.27+ where StatefulSetAutoDeletePVC went into BETA (GA as of 1.32). That feels like a good enough number of versions/time that we don't need to lock this behind a feature gate/flag, but let me know if you'd want me to add that so this doesn't break on older clusters.