feat: df namespace override helm #420
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening PR for solving issue: #403,
If the user simply wants to install the operator in a custom namespace (e.g., my-ops) instead of default, they do not need any changes to the code.
They can just run:
helm install dragonfly-operator ./charts/dragonfly-operator --namespace my-ops --create-namespaceSince the original code used {{ .Release.Namespace }}, Helm automatically populates that variable with whatever is passed to the --namespace flag.
The reason for
namespaceOverridefiles changes and why I had to touch all these files is for Subcharts or GitOps workflows. If we must support the namespaceOverride value. Helm templates are explicit; we cannot "inject" a namespace into a Deployment manifest without writing the line namespace: {{ ... }} in that file.If we move the "main" component (the Operator Deployment) to a custom namespace, we must move everything it depends on as well, or the deployment will break.