fix(e2e): wait for PhaseReady before accessing master pod#516
Merged
Abhra303 merged 1 commit intodragonflydb:mainfrom Apr 9, 2026
Merged
Conversation
Single-replica tests waited on PhaseResourcesCreated, which is set before the lifecycle controller runs configureReplication and labels the master pod, racing checkAndK8sPortForwardRedis with master election and intermittently failing with "no master pod found".
Abhra303
approved these changes
Apr 9, 2026
Contributor
Abhra303
left a comment
Abhra303
left a comment
There was a problem hiding this comment.
LGTM, Thanks for the fix! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-replica tests waited on PhaseResourcesCreated, which is set before the lifecycle controller runs configureReplication and labels the master pod, racing checkAndK8sPortForwardRedis with master election and intermittently failing with "no master pod found".