Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CMake build system to replace cxx_test with helio_cxx_test across all test definitions and updates the helio subproject commit reference. This appears to be migrating to a new test framework or build macro provided by the helio dependency.
Key changes:
- Replaced all
cxx_testmacro calls withhelio_cxx_testacross CMakeLists.txt files - Updated helio subproject to commit ba812d2df851b6d17b8e3c0f84bce65ac5525caa
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/tiering/CMakeLists.txt | Updated 5 test definitions to use helio_cxx_test |
| src/server/search/CMakeLists.txt | Updated 3 test definitions to use helio_cxx_test |
| src/server/CMakeLists.txt | Updated 27 test definitions to use helio_cxx_test |
| src/facade/CMakeLists.txt | Updated 4 test definitions to use helio_cxx_test |
| src/core/search/CMakeLists.txt | Updated 7 test definitions to use helio_cxx_test |
| src/core/json/CMakeLists.txt | Updated 2 test definitions to use helio_cxx_test |
| src/core/CMakeLists.txt | Updated 25 test definitions to use helio_cxx_test |
| helio | Updated subproject commit reference |
glevkovich
force-pushed
the
glevkovich/tmp
branch
2 times, most recently
from
c8ecd06 to
d257bd3
Compare
glevkovich
force-pushed
the
glevkovich/tmp
branch
from
d257bd3 to
778697e
Compare
Signed-off-by: Gil Levkovich <[email protected]>
glevkovich
force-pushed
the
glevkovich/tmp
branch
from
778697e to
4b71f5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dummy pr - do not merge