feat: remove host_id and task_id in RegisterPersistentCachePeerRequest#442
Merged
feat: remove host_id and task_id in RegisterPersistentCachePeerRequest#442
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
force-pushed
the
feature/registry
branch
from
096fa43 to
124503e
Compare
CormickKneey
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to update the
RegisterPersistentCachePeerRequeststructure across multiple files and a version bump in theCargo.tomlfile. The most important changes involve removing thehost_idandtask_idfields from the request structure and reordering the remaining fields.Updates to
RegisterPersistentCachePeerRequeststructure:pkg/apis/scheduler/v2/scheduler.proto: Removedhost_idandtask_idfields and reordered remaining fields inRegisterPersistentCachePeerRequest.proto/scheduler.proto: Removedhost_idandtask_idfields and reordered remaining fields inRegisterPersistentCachePeerRequest.src/scheduler.v2.rs: Removedhost_idandtask_idfields and reordered remaining fields inRegisterPersistentCachePeerRequest.pkg/apis/scheduler/v2/scheduler.pb.validate.go: Removed validation checks forhost_idandtask_idfields inRegisterPersistentCachePeerRequest.Version update:
Cargo.toml: Bumped version from2.1.6to2.1.7.Related Issue
Motivation and Context