feat: remove digest field in PersistentCacheTask#443
Merged
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes primarily focused on removing the
digestfield and its associated validation logic from various files, as well as updating versioning information. The most important changes include the removal ofdigestvalidation logic, updates to thePersistentCacheTaskmessage, and version increment in theCargo.tomlfile.Removal of
digestfield and validation logic:pkg/apis/common/v2/common.pb.validate.go: Removed the validation logic for thedigestfield from thePersistentCacheTaskstruct.pkg/apis/common/v2/common.pb.validate.go: Removed the_PersistentCacheTask_Digest_Patternregex pattern.pkg/apis/common/v2/common.proto: Removed thedigestfield from thePersistentCacheTaskmessage and adjusted the field numbers of subsequent fields.pkg/apis/scheduler/v2/scheduler.pb.go: Removed thedigestfield from theUploadPersistentCacheTaskStartedRequeststruct and adjusted the field numbers of subsequent fields. [1] [2] [3]Version increment:
Cargo.toml: Incremented the version from2.1.7to2.1.8.Related Issue
Motivation and Context