feat(dfget): add support for digest-manifest (#1561) #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
+ Coverage 42.89% 44.56% +1.67%
==========================================
Files 75 75
Lines 21159 21241 +82
==========================================
+ Hits 9077 9467 +390
+ Misses 12082 11774 -308
🚀 New features to boost your workflow:
|
pirDOL
force-pushed
the
main
branch
7 times, most recently
from
45b9e8c to
d6d2560
Compare
Author
done. |
chlins
requested changes
Jan 6, 2026
| let mut digests = HashMap::new(); | ||
| let mut line_num = 0; | ||
|
|
||
| for line in content.lines() { |
Member
There was a problem hiding this comment.
for (line_num, line) in content.lines().enumerate()
| } | ||
|
|
||
| // Parse line: <algorithm>:<digest> <filepath> | ||
| let parts: Vec<&str> = line.split_whitespace().collect(); |
| } | ||
|
|
||
| // Remove trailing '/' from URL if present | ||
| let mut base_url = url.to_string(); |
Member
There was a problem hiding this comment.
let base_url = url.as_str().trim_end_matches('/');
| ) -> Result<()> { | ||
| for entry in file_entries { | ||
| // Check if the entry URL exists in digests hashmap using exact match | ||
| if digests.get(&entry.url).is_none() { |
mingcheng
reviewed
Jan 14, 2026
| } | ||
|
|
||
| // Remove trailing '/' from URL if present | ||
| let base_url = url.as_str().trim_end_matches('/'); |
Member
There was a problem hiding this comment.
Move the 'base_url' out of the loop to improve performance.
mingcheng
reviewed
Jan 14, 2026
Comment on lines
678
to
690
| // Parse line: <algorithm>:<digest> <filepath> | ||
| let (digest_part, filepath_part) = match line.split_once(char::is_whitespace) { | ||
| Some((digest, filepath)) if !filepath.trim().is_empty() => (digest, filepath), | ||
| Some(_) | None => { | ||
| return Err(Error::DigestManifestParseFailed { | ||
| filepath: manifest_path.to_string_lossy().to_string(), | ||
| error: format!( | ||
| "invalid digest manifest format at line {}: expected '<algorithm>:<digest> <filepath>'", | ||
| line_num | ||
| ), | ||
| }); | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
Suggested change
| // Parse line: <algorithm>:<digest> <filepath> | |
| let (digest_part, filepath_part) = match line.split_once(char::is_whitespace) { | |
| Some((digest, filepath)) if !filepath.trim().is_empty() => (digest, filepath), | |
| Some(_) | None => { | |
| return Err(Error::DigestManifestParseFailed { | |
| filepath: manifest_path.to_string_lossy().to_string(), | |
| error: format!( | |
| "invalid digest manifest format at line {}: expected '<algorithm>:<digest> <filepath>'", | |
| line_num | |
| ), | |
| }); | |
| } | |
| }; | |
| // Parse line: <algorithm>:<digest> <filepath> | |
| // Use `split_once` for cleaner parsing logic and clearer error handling. | |
| let (digest_part, filepath_part) = line.split_once(char::is_whitespace) | |
| .filter(|(_, fp)| !fp.trim().is_empty()) | |
| .ok_or_else(|| Error::DigestManifestParseFailed { | |
| filepath: manifest_path.to_string_lossy().to_string(), | |
| error: format!( | |
| "invalid digest manifest format at line {}: expected '<algorithm>:<digest> <filepath>'", | |
| display_line_num | |
| ), | |
| })?; |
Member
There was a problem hiding this comment.
To avoid duplicated match sentences.
mingcheng
reviewed
Jan 14, 2026
| format!("{}/{}", base_url, filepath) | ||
| }; | ||
|
|
||
| digests.insert(key, digest_part.to_string()); |
Member
There was a problem hiding this comment.
Suggest avoiding the duplicate item before returning the parsed data.
Signed-off-by: pirDOL <pirdol@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(dfget): add support for digest-manifest
Related Issue
#1561
Screenshots (if appropriate)