docs: deprecate local approvers and maintainers files#1888
Open
mingcheng wants to merge 2 commits intodragonflyoss:masterfrom
Open
docs: deprecate local approvers and maintainers files#1888mingcheng wants to merge 2 commits intodragonflyoss:masterfrom
mingcheng wants to merge 2 commits intodragonflyoss:masterfrom
Conversation
- remove local lists for approvers and maintainers - add migration notices pointing to community repository - include links to updated lists in community repo Signed-off-by: mingcheng <mingcheng@apache.org>
There was a problem hiding this comment.
Pull request overview
Deprecates the local APPROVERS.md and MAINTAINERS.md lists in this repo and replaces them with short migration notices that point contributors to the canonical lists maintained in the dragonflyoss/community repository.
Changes:
- Removed the in-repo maintainers table and replaced it with a migration notice linking to the community repo.
- Removed the in-repo approvers table and replaced it with a migration notice linking to the community repo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
MAINTAINERS.md |
Replaces the local maintainers list with a migration notice and link to the community-managed list. |
APPROVERS.md |
Replaces the local approvers list with a migration notice and link to the community-managed list. |
| | [Fricounet](https://github.com/Fricounet) | Baptiste Girard-Carrabin | baptiste.girardcarrabin@datadoghq.com | DataDog | | ||
|
|
||
| <!-- markdownlint-restore --> | ||
| This file is no longer maintained and has migrated to community repositories. Please refer to the [community repository](https://github.com/dragonflyoss/community/blob/master/roles/Maintainers.md) for the latest maintainers list. No newline at end of file |
There was a problem hiding this comment.
Grammar/wording: this says "migrated to community repositories" but then points to a single repository. Consider changing to something like "has migrated to the community repository" (or otherwise keep plurality consistent).
Suggested change
| This file is no longer maintained and has migrated to community repositories. Please refer to the [community repository](https://github.com/dragonflyoss/community/blob/master/roles/Maintainers.md) for the latest maintainers list. | |
| This file is no longer maintained and has migrated to the community repository. Please refer to the [community repository](https://github.com/dragonflyoss/community/blob/master/roles/Maintainers.md) for the latest maintainers list. |
| | [Zephyr](https://github.com/Zephyrcf) | Changfu Zhang | zinsist777@gmail.com | University of Science and Technology Beijing | | ||
|
|
||
| <!-- markdownlint-restore --> | ||
| This file is no longer maintained and has migrated to community repositories. Please refer to the [community repository](https://github.com/dragonflyoss/community/blob/master/roles/Approvers.md) for the latest approvers list. No newline at end of file |
There was a problem hiding this comment.
Grammar/wording: this says "migrated to community repositories" but then links to a single repository. Consider changing to "has migrated to the community repository" (or keep plurality consistent).
Suggested change
| This file is no longer maintained and has migrated to community repositories. Please refer to the [community repository](https://github.com/dragonflyoss/community/blob/master/roles/Approvers.md) for the latest approvers list. | |
| This file is no longer maintained and has migrated to the community repository. Please refer to the [community repository](https://github.com/dragonflyoss/community/blob/master/roles/Approvers.md) for the latest approvers list. |
Member
Author
|
Please merge this PR after the following PR is merged: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Related Issues
Change Type
Please select the type of change your pull request relates to:
Self-Checklist
Before submitting a pull request, please ensure you have completed the following: