Update: Added an optional endpoint to GCS filesystem schema #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
NGizila
force-pushed
the
feature/2.7.x-gcs_custom_endpoint
branch
from
82e7ce2 to
e025ee1
Compare
Owner
|
Hi, thanks for your contribution. Please sign our CLA so we can proceed with the review. That said, I'm a bit hesitant to review/merge this as I’m currently unable to test it myself |
Author
|
Hello, I signed the CLA. |
Author
|
Hello, also for the information, this PR is dependant on sftpgo/sdk project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configurable custom GCS endpoint support. Users can override the default GCS API endpoint, mirroring the flexibility available in AWS and Azure, allowing the system to connect to S3NS (french provider "S3NS Trusted Cloud" compatible with GCS library) and other GCS-compatible storage backends.
The default is "storage.googleapis.com", but now user can overwrite it by specifying for example the endpoint "storage.s3nsapis.fr".
Please note, that currently in the code you will find a reference to forked sdk repository upgraded with "GCS custom endpoint".
I've created a corresponding Merge Request in sftpgo/sdk original project that add an endpoint line to GCS filesystem schema. If you approve SDK merge request I will be able to update it in current project.
Added changes are related to created issue by @sylguyot : Add endpoint parameter to GCS Storage backend
Checklist for Pull Requests