Skip to content

Commit d1cfd93

Browse files
LebedevRImemfrob
authored andcommitted
[X86][Costmodel] Load/store i8 Stride=4 VF=16 interleaving costs
While we already model this tuple, the values are divergent from reality, so fix them. The only sched models that for cpu's that support avx2 but not avx512 are: haswell, broadwell, skylake, zen1-3 For load we have: https://godbolt.org/z/TrGW7cKsE - for intels `Block RThroughput: =24.0`; for ryzens, `Block RThroughput: <=12.0` So pick cost of `24`. For store we have: https://godbolt.org/z/Mh7qaqEfe - for intels `Block RThroughput: =8.0`; for ryzens, `Block RThroughput: <=4.0` So pick cost of `8`. I'm directly using the shuffling asm the llc produced, without any manual fixups that may be needed to ensure sequential execution. Reviewed By: RKSimon Differential Revision: https://reviews.llvm.org/D110970
1 parent 5c4922f commit d1cfd93

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

llvm/lib/Target/X86/X86TargetTransformInfo.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5097,7 +5097,7 @@ InstructionCost X86TTIImpl::getInterleavedMemoryOpCostAVX2(
50975097
{4, MVT::v2i8, 4}, // (load 8i8 and) deinterleave into 4 x 2i8
50985098
{4, MVT::v4i8, 4}, // (load 16i8 and) deinterleave into 4 x 4i8
50995099
{4, MVT::v8i8, 12}, // (load 32i8 and) deinterleave into 4 x 8i8
5100-
{4, MVT::v16i8, 39}, // (load 64i8 and) deinterleave into 4 x 16i8
5100+
{4, MVT::v16i8, 24}, // (load 64i8 and) deinterleave into 4 x 16i8
51015101
{4, MVT::v32i8, 80}, // (load 128i8 and) deinterleave into 4 x 32i8
51025102

51035103
{4, MVT::v2i16, 6}, // (load 8i16 and) deinterleave into 4 x 2i16
@@ -5147,7 +5147,7 @@ InstructionCost X86TTIImpl::getInterleavedMemoryOpCostAVX2(
51475147
{4, MVT::v2i8, 4}, // interleave 4 x 2i8 into 8i8 (and store)
51485148
{4, MVT::v4i8, 4}, // interleave 4 x 4i8 into 16i8 (and store)
51495149
{4, MVT::v8i8, 4}, // interleave 4 x 8i8 into 32i8 (and store)
5150-
{4, MVT::v16i8, 10}, // interleave 4 x 16i8 into 64i8 (and store)
5150+
{4, MVT::v16i8, 8}, // interleave 4 x 16i8 into 64i8 (and store)
51515151
{4, MVT::v32i8, 12}, // interleave 4 x 32i8 into 128i8 (and store)
51525152

51535153
{4, MVT::v2i16, 2}, // interleave 4 x 2i16 into 8i16 (and store)

llvm/test/Analysis/CostModel/X86/interleaved-load-i8-stride-4.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ target triple = "x86_64-unknown-linux-gnu"
2929
; AVX2: LV: Found an estimated cost of 5 for VF 2 For instruction: %v0 = load i8, i8* %in0, align 1
3030
; AVX2: LV: Found an estimated cost of 5 for VF 4 For instruction: %v0 = load i8, i8* %in0, align 1
3131
; AVX2: LV: Found an estimated cost of 13 for VF 8 For instruction: %v0 = load i8, i8* %in0, align 1
32-
; AVX2: LV: Found an estimated cost of 41 for VF 16 For instruction: %v0 = load i8, i8* %in0, align 1
32+
; AVX2: LV: Found an estimated cost of 26 for VF 16 For instruction: %v0 = load i8, i8* %in0, align 1
3333
; AVX2: LV: Found an estimated cost of 84 for VF 32 For instruction: %v0 = load i8, i8* %in0, align 1
3434
;
3535
; AVX512: LV: Found an estimated cost of 1 for VF 1 For instruction: %v0 = load i8, i8* %in0, align 1

llvm/test/Analysis/CostModel/X86/interleaved-store-i8-stride-4.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ target triple = "x86_64-unknown-linux-gnu"
2929
; AVX2: LV: Found an estimated cost of 5 for VF 2 For instruction: store i8 %v3, i8* %out3, align 1
3030
; AVX2: LV: Found an estimated cost of 5 for VF 4 For instruction: store i8 %v3, i8* %out3, align 1
3131
; AVX2: LV: Found an estimated cost of 5 for VF 8 For instruction: store i8 %v3, i8* %out3, align 1
32-
; AVX2: LV: Found an estimated cost of 12 for VF 16 For instruction: store i8 %v3, i8* %out3, align 1
32+
; AVX2: LV: Found an estimated cost of 10 for VF 16 For instruction: store i8 %v3, i8* %out3, align 1
3333
; AVX2: LV: Found an estimated cost of 16 for VF 32 For instruction: store i8 %v3, i8* %out3, align 1
3434
;
3535
; AVX512: LV: Found an estimated cost of 1 for VF 1 For instruction: store i8 %v3, i8* %out3, align 1

0 commit comments

Comments
 (0)