Add circular type dependency detection #617
Open
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating custom types that reference each other (like type_1 has a field of type_2, and type_2 has a field of type_1), the app should show an error in the issues panel. This was missing before - only table relationships were checked for circular dependencies, not custom type field references. Changes: - Added checkCircularTypes function to detect type reference loops - Added 'circular_type_dependency' translation key in English and Spanish - Now shows proper error: 'Circular type dependency involving type X' Fixes the issue where users could create invalid type structures without any warning.
|
@Ishank307 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds validation to detect circular dependencies in custom types and shows proper error messages in the issues panel.
Problem
When users create custom types that reference each other (e.g.,
type_1has a field oftype_2, andtype_2has a field oftype_1), no error was shown. This could lead to invalid type structures.Solution
checkCircularTypesfunction to detect type reference loopsHow to Test
type_1with a field of typetype_2type_2with a field of typetype_1Type of Change
Fixes missing validation for circular type references.
FIxes Show error for circular type references #615