Fix Delete key behaviour and improve element validation #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes the Delete key shortcut not triggering the deletion logic in the editor.
Summary of changes:
useEffectto handle Delete/Backspace key events at the component levellayout.readonly→layout.readOnlyselectedElementbefore calling the delete functionUsing
useEffectensures that Delete and Backspace work consistently across tables, notes, areas matching the behaviour documented in the shortcuts list.Tested on macOS + Chrome (normal & incognito).