Skip to content

Conversation

@rounittxx
Copy link

@rounittxx rounittxx commented Nov 24, 2025

This PR Fixes the Delete key shortcut not triggering the deletion logic in the editor.

Summary of changes:

  • Added useEffect to handle Delete/Backspace key events at the component level
  • Corrected layout.readonlylayout.readOnly
  • Added a validation check to ensure a valid selectedElement before calling the delete function

Using useEffect ensures that Delete and Backspace work consistently across tables, notes, areas matching the behaviour documented in the shortcuts list.

Tested on macOS + Chrome (normal & incognito).

@vercel
Copy link

vercel bot commented Nov 24, 2025

Someone is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@rounittxx
Copy link
Author

@1ilit kindly review my pr and let me know if any changes are needed :)

@rounittxx rounittxx closed this Nov 24, 2025
@rounittxx
Copy link
Author

i found a better way to solve the issue

@rounittxx rounittxx deleted the fix-delete-key-shortcut branch November 24, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant