Skip to content

Add maketext#66

Merged
drdrew42 merged 2 commits intodrdrew42:masterfrom
taniwallach:add-maketext
Aug 19, 2021
Merged

Add maketext#66
drdrew42 merged 2 commits intodrdrew42:masterfrom
taniwallach:add-maketext

Conversation

@taniwallach
Copy link
Copy Markdown
Contributor

Get maketext and some Hebrew translations working in the Standalone renderer.

The code changes are copied or directly based on what is in https://github.com/openwebwork/webwork2.

Screenshot from an English OPL problem via the XBlock when the language was set to heb with these changes:
Sample-Hebrew-Feedback-Standalone-Renderer

Right-to-left formatting needs for Hebrew were not addressed in this PR.

Copy link
Copy Markdown
Owner

@drdrew42 drdrew42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taniwallach thank you SO much for tackling this feature. Are these .po files taken verbatim from ww2? i.e. can we lift the other languages as well, or will there need to be further modification?

@drdrew42 drdrew42 merged commit 971d663 into drdrew42:master Aug 19, 2021
@taniwallach
Copy link
Copy Markdown
Contributor Author

@taniwallach thank you SO much for tackling this feature.

I'm hoping that we'll get closer to production use in Hebrew soon, so it was a significant need here.

Are these .po files taken verbatim from ww2? i.e. can we lift the other languages as well, or will there need to be further modification?

No - the files are much smaller as the LMS side of WW2 has much more use of translated strings. From what I recall there are some differences here and there in the English phrases (probably due to changes on the ww2 side). I did manually copy (and the edit) phrases which I could quickly find from the ww2 heb.po file, but some just manually typed in translations.

@taniwallach
Copy link
Copy Markdown
Contributor Author

For the record, the translation code from the PR was working for things handled by:

  • lib/WeBWorK/lib/WeBWorK/Utils/AttemptsTable.pm and
  • lib/RenderApp/Controller/FormatRenderedProblem.pm.

However, maketext was not working during the processing of the PG code, so messages which were translated properly on WeBWorK/PG 2.16 systems were not handled by the standalone renderer with the code from this PR.

#86 seems to resolve that problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants