-
Notifications
You must be signed in to change notification settings - Fork 13
Fix contribution hooks and setup #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove unused type ignore for docker import in container.py - Remove unused type ignore for yaml import in challenges.py 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add return type annotations to __init__ and main functions - Add type parameter to re.Pattern[str] for proper typing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add null check for generator before calling wrap() method - Re-add necessary type ignore comments for untyped imports - Fix union-attr error in cache retry logic 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add type ignore for typer import to handle missing stubs - Resolve final mypy type checking errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix 'algorithimic' to 'algorithmic' in system prompt - Fix 'shoud' to 'should' in instructions - Enhance typer import ignore to cover multiple error types 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added type: ignore[misc] for BaseModel/Model subclassing issues - Added type: ignore[no-any-return] for pydantic model validation - Set warn_unused_ignores = false to handle environment differences - Pre-commit and local mypy now both pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This reverts commit 49e05f0.
GangGreenTemperTatum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @zmackie , thanks for the submission - apologies, i'm unclear what the problem and objective is here? can you re-write these in individual PRs and cleaner commits please?
|
@GangGreenTemperTatum Heya sorry for the poor explanation! Basically I tried to go through: https://github.com/dreadnode/AIRTBench-Code/blob/main/docs/contributing.md#getting-started from scratch, and found that actually getting
Happy to break this up into some way that makes sense. Maybe including the binary dependencies in one, converging on Also happy to discusss more sync in discord if that's easier. |
|
hey @zmackie thanks and never any need to apologize :)
i dont understand why this would be needed? apologies if i am misunderstanding. install pre-commits via brew is normally my flow and i havent had any problems here
yeah always happy to chat where possible so always feel free to reach out! :) it may be me, i just dont see the blocker so at the moment im more leaning towards putting this as some kind of stretch or address it if it becomes a problem later if SGTY? tyia! |
|
Sure thing. Happy to leave this as a stretch! |
yeah, sorry if that was lack of context on my part there - id love to see what ideas you have for the next iteration of the base agent code? IE |
Fix contribution hooks and setup
This is a big PR, my apologies.
The goal of this PR is to make the contribution workflows actually work. Most of the changes are formatting.
However, notice below evidence of many green hooks actually running post-commit!
Key Changes:
uvfor tooling (this was a decision, but it seemed that it would simplify things)Changes should all be superficial, so no functionality was effected. That said, there aren't tests so my best validation was running the benchmark: