Skip to content

chore: do not fail serve on container pulls #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GangGreenTemperTatum wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: do not fail serve on container pulls #11

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85cbee6
chore: do not fail serve on container pulls
GangGreenTemperTatum Jan 31, 2025
0e31db6
fix: use clone and consistent pull function build calls across robopages
GangGreenTemperTatum Feb 2, 2025
1b38d07
fix: try fix ci E0063
GangGreenTemperTatum Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/runtime/docker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ async fn run_command(command: &str, args: &[&str]) -> anyhow::Result<()> {
}

pub(crate) async fn pull_image(image: &str, platform: Option<String>) -> anyhow::Result<()> {
run_command(
let result = run_command(
"sh",
&[
"-c",
Expand All @@ -87,7 +87,13 @@ pub(crate) async fn pull_image(image: &str, platform: Option<String>) -> anyhow:
),
],
)
.await
.await;

if let Err(e) = result {
log::error!("Docker pull encountered an error: {}", e);
}

Ok(())
}

pub(crate) async fn build_image(name: &str, path: &str) -> anyhow::Result<()> {
Expand Down