Skip to content

refactor(image): Explicitly cast array returns #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briangreunke merged 2 commits into from
Nov 19, 2025
Merged

refactor(image): Explicitly cast array returns #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe61697
refactor(image): Explicitly cast array returns
briangreunke Nov 19, 2025
2473ed3
chore: suppress typing error
briangreunke Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dreadnode/data_types/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def canonical_array(self) -> "np.ndarray[t.Any, np.dtype[np.float32]]":
Returns:
float32 numpy array in [0,1] range, HWC format
"""
return self._canonical_array.copy() # Always return a copy for safety
return t.cast("np.ndarray[t.Any, np.dtype[np.float32]]", self._canonical_array.copy()) # type: ignore[redundant-cast]

@property
def shape(self) -> tuple[int, ...]:
Expand Down Expand Up @@ -328,7 +328,7 @@ def to_numpy(self, dtype: t.Any = np.float32) -> "np.ndarray[t.Any, t.Any]":
# Keep float range [0, 1]
arr = arr.astype(dtype)

return arr
return t.cast("np.ndarray[t.Any, t.Any]", arr)

def to_pil(self) -> "PILImage":
"""Returns the image as a Pillow Image object."""
Expand Down