4.5 Patch - Adjustment to how loading leaves in the octree works#80
Open
chase102496 wants to merge 2 commits intodreadpon:masterfrom
Open
4.5 Patch - Adjustment to how loading leaves in the octree works#80chase102496 wants to merge 2 commits intodreadpon:masterfrom
chase102496 wants to merge 2 commits intodreadpon:masterfrom
Conversation
|
Can confirm this fixed the issue for me too on a scene with several thousands of meshes that weren't recognized anymore. TYSM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a follow-up to PR #76 where Logger was changed to CustomLogger
This is a fix for #78
Had to do with the change of duplication in 4.5.
When a node has is_leaf = true BUT also has child_nodes, the OctreeLeaf thinks it should manage instances, but the node is actually supposed to delegate to children. This creates the desync.
In mmi_octree_node.gd, in restore_after_load(), I forced recalculation of is_leaf based on actual state instead of assuming it. It's not performant, but it works for 4.5 testing on a full game (where I have tons and tons of meshes and scenes)