Fix legacy stage_direction references after line_type migration #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python Test Results 1 files 1 suites 17s ⏱️ Results for commit 7517332. ♻️ This comment has been updated with latest results. |
Client Test Results34 tests 34 ✅ 0s ⏱️ Results for commit 7517332. ♻️ This comment has been updated with latest results. |
The stage_direction boolean field was removed in commit 08b6424 and replaced with the line_type enum. Updated 3 production files and 1 test file that still referenced the old attribute. Changed all instances of `if line.stage_direction:` to `if line.line_type != ScriptLineType.DIALOGUE:` to properly filter out non-dialogue lines (stage directions, cue lines, and spacing). Files modified: - server/controllers/api/show/characters.py (line 201) - server/controllers/api/show/cast.py (line 189) - server/utils/show/mic_assignment.py (line 127) - server/test/utils/show/test_mic_assignment.py (multiple mocks) Fixes #812 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Tim020
force-pushed
the
issue/stage-direction-hangover
branch
from
ee8b8a1 to
ab26331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes legacy code that still referenced the removed
stage_directionboolean field after the migration to theline_typeenum in commit 08b6424.Changes Made
Updated 4 files that were still using
if line.stage_direction:checks:server/controllers/api/show/characters.py(line 201)ScriptLineTypeimportline_type != ScriptLineType.DIALOGUEserver/controllers/api/show/cast.py(line 189)ScriptLineTypeimportline_type != ScriptLineType.DIALOGUEserver/utils/show/mic_assignment.py(line 127)ScriptLineTypeimportline_type != ScriptLineType.DIALOGUEserver/test/utils/show/test_mic_assignment.py(multiple lines)ScriptLineTypeimportline_typeinstead ofstage_directionWhy
!= DIALOGUEinstead of== STAGE_DIRECTION?Using
!= DIALOGUEcorrectly filters out ALL non-dialogue line types:This makes the code more future-proof and semantically accurate.
Test Plan
test_mic_assignment.pypass/api/v1/show/character/statsworks without errors/api/v1/show/cast/statsshould work without errorsRelated Issues
Fixes #812
🤖 Generated with Claude Code