Skip to content

Conversation

@Tim020
Copy link
Contributor

@Tim020 Tim020 commented Jan 7, 2026

Summary

Migrates from the deprecated node-sass (LibSass) to the actively maintained sass (Dart Sass) package. This resolves issue #821 and ensures DigiScript uses a supported Sass implementation.

Changes:

  • ✅ Removed node-sass 7.0.3 (deprecated LibSass wrapper)
  • ✅ Removed sass-loader 13.3.3 (unused with Vite)
  • ✅ Kept sass 1.97.1 (Dart Sass - actively maintained)

Benefits:

  • Active maintenance and regular updates
  • Better Node 24.x compatibility
  • Improved compilation performance
  • Future-proof Sass implementation
  • No configuration changes needed (Vite handles SCSS natively)

Test Plan

  • Clean install from scratch succeeds
  • Production build completes successfully
  • All 717 modules transform correctly
  • SCSS compilation works perfectly
  • Build output identical to before migration
  • ESLint passes with no issues
  • Verified with local server running

References

🤖 Generated with Claude Code

Removes deprecated node-sass (LibSass) in favor of the actively maintained
sass (Dart Sass) package. Also removes unused sass-loader since Vite handles
SCSS preprocessing natively.

- Remove node-sass 7.0.3 (deprecated)
- Remove sass-loader 13.3.3 (unused with Vite)
- Keep sass 1.97.1 (Dart Sass)

Benefits:
- Active maintenance and updates
- Better Node 24.x compatibility
- Improved performance
- Future-proof Sass implementation

Fixes #821

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions github-actions bot added client Pull requests changing front end code xlarge-diff labels Jan 7, 2026
@Tim020 Tim020 added the claude Issues created by Claude label Jan 7, 2026
@Tim020 Tim020 linked an issue Jan 7, 2026 that may be closed by this pull request
8 tasks
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Client Test Results

34 tests  ±0   34 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit fdb97ac. ± Comparison against base commit 6a9f37a.

@Tim020 Tim020 enabled auto-merge January 7, 2026 01:27
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Python Test Results

  1 files  ±0    1 suites  ±0   19s ⏱️ ±0s
253 tests ±0  253 ✅ ±0  0 💤 ±0  0 ❌ ±0 
258 runs  ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fdb97ac. ± Comparison against base commit 6a9f37a.

@Tim020 Tim020 merged commit f3c596e into dev Jan 7, 2026
18 checks passed
@Tim020 Tim020 deleted the migrate-to-dart-sass branch January 7, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude Issues created by Claude client Pull requests changing front end code xlarge-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from node-sass to sass (Dart Sass)

2 participants