Towboot PinePhone compatibility#399
Open
ArenM wants to merge 3 commits intodreemurrs-embedded:masterfrom
Open
Conversation
Contributor
Author
|
Marking as ready since #398 got fixed |
DrRac27
reviewed
Jun 14, 2022
Move the u-boot configuration to the device meta-package, and change mmc_bootdev to devnum for compatibility with tow-boot. When booting from tow-boot mmc_bootdev points at the emmc, even if arch is installed to the sd card, devnum gets set to be the correct device though.
tytan652
reviewed
Dec 7, 2022
Danct12
added
enhancement
Contributor
Author
|
I've tested this to make sure it boots with both the uboot-pinephone and tow-boot when booting from the sd card and emmc. And since it seemed like there might be a little confusion, this doesn't replace uboot-pinephone with tow-boot by default, it just makes it so tow-boot can boot arch from the sd card. |
Danct12
reviewed
Mar 30, 2023
Danct12
reviewed
Mar 30, 2023
Move the u-boot configuration to the device meta-package, and change mmc_bootdev to devnum for compatibility with tow-boot. When booting from tow-boot mmc_bootdev points at the emmc, even if arch is installed to the sd card, devnum gets set to be the correct device though.
These files are now installed in the device meta-packages
Contributor
Author
|
bump, is there anything blocking this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The u-boot boot script thinks it's booting from emmc even if it's booting an sd card when using tow-boot. It seems to be possible to resolve this by replacing
mmc_bootdevwithdevnum.This also makes it possible to remove the uboot-pinephone package when using tow-boot.
I'm suspicious of the code duplication this causes, and wonder if it would be better to use something like Debian's u-boot-menu script, Unfortunately that doesn't support device tree overlays yet, so that might be a project for a later time.