Open
Conversation
…es in SQL generation. Added tests for incremental predicates and verified parameter passing through the macro chain. This addresses potential issues with SQL keywords and improves overall robustness of the incremental materialization process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incremental_predicates option not being applied in merge strategy
Description
Fixes issue #306 where the
incremental_predicatesconfig option had no effect when using the merge incremental strategy.Root Cause:
The
incremental_predicatesconfig was being read from the model configuration but wasn't being passed through to the merge SQL generation macro. Thedbt_dremio_get_incremental_sqlmacro was hardcoded to passincremental_predicates=noneto the merge strategy, ignoring any predicates defined in the model config.Changes Made:
incremental_predicatesparameter to thedbt_dremio_get_incremental_sqlmacro signature instrategies.sqlincremental_predicateswhen callingdbt_dremio_get_incremental_sqlinincremental.sqlincremental_predicatesparameter instead of hardcodingnoneFiles Modified:
dbt/include/dremio/macros/materializations/incremental/incremental.sql- Pass incremental_predicates to the SQL generation macrodbt/include/dremio/macros/materializations/incremental/strategies.sql- Accept and forward incremental_predicates parameterTest Results
Changelog
Contributor License Agreement
Related Issue
#306 - incremental_predicates option has no effect