Skip to content

Fixing an issue with lineage api response #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniket-s-kulkarni wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixing an issue with lineage api response #74

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93f079e
Supporting DIRECT
aniket-s-kulkarni Oct 27, 2025
fee0acc
Review comments
aniket-s-kulkarni Oct 29, 2025
1416d5b
Merge branch 'main' into dx-110304
aniket-s-kulkarni Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/dremioai/api/dremio/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ class DatasetSubType(UStrEnum):
DIRECT = auto()


def subset_validator(elem: UStrEnum, values: List[UStrEnum]) -> UStrEnum:
def subset_validator(elem: UStrEnum, values: UStrEnum | List[UStrEnum]) -> UStrEnum:
if elem in values:
return elem
raise ValidationError(f"{elem} not in {values}")
raise ValueError(f"{elem} not in {values}")


class LineageBase(BaseModel):
Expand All @@ -64,7 +64,7 @@ class LineageBase(BaseModel):
class LineageSource(LineageBase):
type: Annotated[
CatalogItemType,
AfterValidator(partial(subset_validator, values=[CatalogItemType.CONTAINER])),
AfterValidator(partial(subset_validator, values=CatalogItemType)),
]
container_type: Annotated[
ContainerSubType,
Expand All @@ -80,23 +80,20 @@ class LineageSource(LineageBase):
class LineageParents(LineageBase):
type: Annotated[
CatalogItemType,
AfterValidator(partial(subset_validator, values=[CatalogItemType.DATASET])),
AfterValidator(partial(subset_validator, values=CatalogItemType)),
]
dataset_type: Annotated[
DatasetSubType,
AfterValidator(
partial(
subset_validator,
values=[DatasetSubType.PROMOTED, DatasetSubType.VIRTUAL],
)
partial(subset_validator, values=DatasetSubType),
),
] = Field(..., alias="datasetType")


class LineageChildren(LineageBase):
type: Annotated[
CatalogItemType,
AfterValidator(partial(subset_validator, values=[CatalogItemType.DATASET])),
AfterValidator(partial(subset_validator, values=CatalogItemType)),
Copy link

@colan-dremio colan-dremio Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question for all the changes to CatalogItemType, they looked correct to me before

]
dataset_type: Annotated[
DatasetSubType,
Expand Down