Changes more errors to use the new ErrorCodes generator (#206)

Author: dresende

lib/AggregateFunctions.js

@@ -4,10 +4,10 @@ module.exports = AggregateFunctions;
 
 function AggregateFunctions(opts) {
 	if (typeof opts.driver.getQuery != "function") {
-		throw new Error("This driver does not support aggregate functions");
+		throw ErrorCodes.generateError(ErrorCodes.NO_SUPPORT, "This driver does not support aggregate functions");
 	}
 	if (!Array.isArray(opts.driver.aggregate_functions)) {
-		throw new Error("This driver does not support aggregate functions");
+		throw ErrorCodes.generateError(ErrorCodes.NO_SUPPORT, "This driver does not support aggregate functions");
 	}
 
 	var aggregates    = [ [] ];
@@ -51,7 +51,7 @@ function AggregateFunctions(opts) {
 		},
 		select: function () {
 			if (arguments.length === 0) {
-				throw new Error("When using append you must at least define one property");
+				throw ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, "When using append you must at least define one property");
 			}
 			opts.properties = opts.properties.concat(Array.isArray(arguments[0]) ?
 			                                                 arguments[0] :
@@ -60,7 +60,7 @@ function AggregateFunctions(opts) {
 		},
 		as: function (alias) {
 			if (aggregates.length === 0) {
-				throw new Error("No aggregate function defined yet");
+				throw ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, "No aggregate functions defined yet");
 			}
 
 			var len = aggregates.length;
@@ -71,13 +71,13 @@ function AggregateFunctions(opts) {
 		},
 		get: function (cb) {
 			if (typeof cb != "function") {
-				throw new Error("You must pass a callback to Model.aggregate().get()");
+				throw ErrorCodes.generateError(ErrorCodes.MISSING_CALLBACK, "You must pass a callback to Model.aggregate().get()");
 			}
 			if (aggregates[aggregates.length - 1].length === 0) {
 				aggregates.length -= 1;
 			}
 			if (aggregates.length === 0) {
-				throw new Error("Missing aggregate functions");
+				throw ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, "Missing aggregate functions");
 			}
 
 			var query = opts.driver.getQuery().select().from(opts.table).select(opts.properties);

lib/ErrorCodes.js

@@ -4,6 +4,8 @@ exports.NO_SUPPORT       = 3;
 exports.MISSING_CALLBACK = 4;
 exports.PARAM_MISSMATCH  = 5;
 
+exports.CONNECTION_LOST  = 10;
+
 Object.defineProperty(exports, "generateError", {
 	value: function (code, message, extra) {
 		var err = new Error(message);

lib/ORM.js

@@ -50,11 +50,11 @@ exports.use = function (connection, proto, opts, cb) {
 
 exports.connect = function (opts, cb) {
 	if (arguments.length === 0 || !opts) {
-		return ORM_Error(new Error("CONNECTION_URL_EMPTY"), cb);
+		return ORM_Error(ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, "CONNECTION_URL_EMPTY"), cb);
 	}
 	if (typeof opts == "string") {
 		if (opts.replace(/\s+/, "").length === 0) {
-			return ORM_Error(new Error("CONNECTION_URL_EMPTY"), cb);
+			return ORM_Error(ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, "CONNECTION_URL_EMPTY"), cb);
 		}
 		opts = url.parse(opts, true);
 	}
@@ -65,7 +65,7 @@ exports.connect = function (opts, cb) {
 		opts.database = (opts.pathname ? opts.pathname.substr(1) : "");
 	}
 	if (!opts.protocol) {
-		return ORM_Error(new Error("CONNECTION_URL_NO_PROTOCOL"), cb);
+		return ORM_Error(ErrorCodes.generateError(ErrorCodes.PARAM_MISSMATCH, "CONNECTION_URL_NO_PROTOCOL"), cb);
 	}
 	// if (!opts.host) {
 	// 	opts.host = opts.hostname = "localhost";
@@ -111,7 +111,7 @@ exports.connect = function (opts, cb) {
 		});
 	} catch (ex) {
 		if (ex.code == "MODULE_NOT_FOUND" || ex.message.indexOf('find module')) {
-			return ORM_Error(new Error("CONNECTION_PROTOCOL_NOT_SUPPORTED"), cb);
+			return ORM_Error(ErrorCodes.generateError(ErrorCodes.NO_SUPPORT, "CONNECTION_PROTOCOL_NOT_SUPPORTED"), cb);
 		}
 		return ORM_Error(ex, cb);
 	}
@@ -138,7 +138,7 @@ function ORM(driver_name, driver, settings) {
 	var onError = function (err) {
 		if (this.settings.get("connection.reconnect")) {
 			if (typeof this.driver.reconnect == "undefined") {
-				return this.emit("error", new Error("Connection lost - driver does not support reconnection"));
+				return this.emit("error", ErrorCodes.generateError(ErrorCodes.CONNECTION_LOST, "Connection lost - driver does not support reconnection"));
 			}
 			this.driver.reconnect(function () {
 				this.driver.on("error", onError);

lib/Property.js

@@ -30,6 +30,7 @@ exports.normalize = function (prop, Settings) {
 
 	if ([ "text", "number", "boolean", "date", "enum", "object", "binary" ].indexOf(prop.type) == -1) {
 		throw new Error("Unknown property type: " + prop.type);
+		throw ErrorCodes.generateError(ErrorCodes.NO_SUPPORT, "Unknown property type: " + prop.type);
 	}
 
 	if (!prop.hasOwnProperty("required") && Settings.get("properties.required")) {