Zero is a valid value for an ID column, don't coerce it to NULL

stueynz · stueynz · commit bb58e477c7de · 2015-12-07T16:05:51.000+13:00
diff --git a/lib/Drivers/DML/redshift.js b/lib/Drivers/DML/redshift.js
@@ -34,7 +34,8 @@ Driver.prototype.insert = function (table, data, keyProperties, cb) {
 		} else {
 			for(i = 0; i < keyProperties.length; i++) {
 				prop = keyProperties[i];
-				ids[prop.name] = data[prop.mapsTo] || null;
+                                // Zero is a valid value for an ID column
+				ids[prop.name] = data[prop.mapsTo] !== undefined ? data[prop.mapsTo] : null;
 			}
 
 			return cb(null, ids);

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,8 @@ Driver.prototype.insert = function (table, data, keyProperties, cb) {`
`34`	`34`	`} else {`
`35`	`35`	`for(i = 0; i < keyProperties.length; i++) {`
`36`	`36`	`prop = keyProperties[i];`
`37`		`- ids[prop.name] = data[prop.mapsTo] \|\| null;`
	`37`	`+ // Zero is a valid value for an ID column`
	`38`	`+ ids[prop.name] = data[prop.mapsTo] !== undefined ? data[prop.mapsTo] : null;`
`38`	`39`	`}`
`39`	`40`
`40`	`41`	`return cb(null, ids);`