Add module-info and compile it with Java 9+#620
Open
tsmock wants to merge 1 commit intodrewnoakes:mainfrom
Open
Add module-info and compile it with Java 9+#620tsmock wants to merge 1 commit intodrewnoakes:mainfrom
tsmock wants to merge 1 commit intodrewnoakes:mainfrom
Conversation
Signed-off-by: Taylor Smock <tsmock@meta.com>
Owner
|
This looks like the long term solution, but until xmp-core sports modules, we are stuck with the approach from #621. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #566.
With that said, this is typically not the preferred method until all dependencies at least have the
Automatic-Module-Namemanifest entry -- ideally, the xmpcore project would add anAutomatic-Module-Nameentry to its manifest, but I somehow doubt that will happen.From the compile-time output:
See also #621 .