Add transfer_vault_depositor_shares instruction#104
Closed
Jesscha wants to merge 5 commits intodrift-labs:masterfrom
Closed
Add transfer_vault_depositor_shares instruction#104Jesscha wants to merge 5 commits intodrift-labs:masterfrom
Jesscha wants to merge 5 commits intodrift-labs:masterfrom
Conversation
Allows a vault depositor to transfer their shares to another existing VaultDepositor account within the same vault. Only the sender needs to sign. Leverages the existing transfer_shares trait method in traits.rs. Includes Rust instruction handler, SDK method, and bankrun tests.
- Add self-transfer guard (from == to depositor) - Add zero amount guard - Validate destination depositor has no pending withdraw - Remove unnecessary mut on drift_user account - Fix invariant check to propagate safe_add errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transfer_vault_depositor_sharesinstruction to the vault program (BE-185)transfer_sharestrait method intraits.rsChanges
transfer_vault_depositor_shares.rs) — accounts validation, equity calculation, share transfer with invariant checksvaultClient.ts) —transferVaultDepositorShares+createTransferVaultDepositorSharesIxanchor buildTest plan
anchor buildsucceeds