program: isolation position init #1757
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbigz
reviewed
Jul 31, 2025
programs/drift/src/controller/pnl.rs
Outdated
| Some(meets_margin_requirement) => meets_margin_requirement, | ||
| None => meets_settle_pnl_maintenance_margin_requirement( | ||
| Some(meets_margin_requirement) if !isolated_position_market_index.is_some() => meets_margin_requirement, | ||
| // TODO check margin for isolate position |
wphan
reviewed
Jul 31, 2025
| } | ||
|
|
||
| fn balance_type(&self) -> &SpotBalanceType { | ||
| &SpotBalanceType::Deposit |
There was a problem hiding this comment.
how does pnl settle if the position has negativepnl?
There was a problem hiding this comment.
oh i see, USDC gets deposited into the perp position, and that gets used as the margin for the perp position, and it's always a deposit never a borrow
0xbigz
reviewed
Aug 14, 2025
| total_withdraws_after, | ||
| market_index: spot_market_index, | ||
| explanation: DepositExplanation::None, | ||
| transfer_user: None, |
There was a problem hiding this comment.
are we planning on tracking isolated positions deposit/withdraws? might need something here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.