Hardening: validate owners and data lengths in native admin handlers#2110
Open
RedaRahmani wants to merge 1 commit intodrift-labs:masterfrom
Open
Hardening: validate owners and data lengths in native admin handlers#2110RedaRahmani wants to merge 1 commit intodrift-labs:masterfrom
RedaRahmani wants to merge 1 commit intodrift-labs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds guard rails around the two “native fast-path” admin handlers in
admin.rs.These handlers skip Anchor account validation and write directly into
accounts[0].datausing fixed byte offsets. That’s fast, but it also means a bad account (wrong owner, wrong sysvar, too-short data, etc.) can lead to unsafe indexing/slicing or accidental writes.What changed
Instead of crashing on bad inputs, the handlers now return standard
ProgramErrors(safe failure).Tests
Notes
No protocol logic or offsets were changed, this is defense-in-depth only (safer validation + predictable errors).