Add missing renames for dispatchNow method on Jobs (#219)

* Add missing renames for dispatchNow method on Jobs

* Add tests for the Laravel 10 Set

* Add missing test for the Laravel 10 Set

Author: GeniJaho

config/sets/laravel100.php

@@ -35,13 +35,15 @@
     $rectorConfig
         ->ruleWithConfiguration(RenamePropertyRector::class, [
             // https://github.com/laravel/laravel/commit/edcbe6de7c3f17070bf0ccaa2e2b785158ae5ceb
-            new RenameProperty('App\Http\Kernel', 'routeMiddleware', 'middlewareAliases'),
+            new RenameProperty('Illuminate\Foundation\Http\Kernel', 'routeMiddleware', 'middlewareAliases'),
         ]);
 
     $rectorConfig
         ->ruleWithConfiguration(RenameMethodRector::class, [
             // https://github.com/laravel/framework/pull/42591/files
             new MethodCallRename('Illuminate\Support\Facades\Bus', 'dispatchNow', 'dispatchSync'),
+            new MethodCallRename('Illuminate\Foundation\Bus\Dispatchable', 'dispatchNow', 'dispatchSync'),
+            new MethodCallRename('Illuminate\Foundation\Bus\DispatchesJobs', 'dispatchNow', 'dispatchSync'),
         ]);
 
     $rectorConfig

duster.json

@@ -5,6 +5,7 @@
         "src"
     ],
     "exclude": [
-        "tests/Rector/**/**/Fixture"
+        "tests/Rector/**/**/Fixture",
+        "tests/Sets/**/Fixture"
     ]
 }

stubs/Illuminate/Foundation/Bus/DispatchesJobs.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Illuminate\Foundation\Bus;
+
+if (class_exists('Illuminate\Foundation\Bus\DispatchesJobs')) {
+    return;
+}
+
+trait DispatchesJobs
+{
+}

stubs/Illuminate/Foundation/Http/Kernel.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Foundation\Http;
+
+if (class_exists('Illuminate\Foundation\Http\Kernel')) {
+    return;
+}
+
+class Kernel
+{
+}

tests/Sets/Laravel100/Fixture/fixture.php.inc

@@ -0,0 +1,59 @@
+<?php
+
+namespace RectorLaravel\Tests\Sets\Laravel100;
+
+use Illuminate\Foundation\Bus\Dispatchable;
+use Illuminate\Foundation\Bus\DispatchesJobs;
+use Illuminate\Support\Facades\Bus;
+
+class DispatchableJobClass
+{
+    use Dispatchable;
+}
+
+class DispatchesJobsClass
+{
+    use DispatchesJobs;
+}
+
+class Kernel extends \Illuminate\Foundation\Http\Kernel
+{
+    protected $routeMiddleware = [];
+}
+
+Bus::dispatchNow(fn () => null);
+DispatchableJobClass::dispatchNow(fn () => null);
+DispatchesJobsClass::dispatchNow(fn () => null);
+dispatch_now(fn () => null);
+
+?>
+-----
+<?php
+
+namespace RectorLaravel\Tests\Sets\Laravel100;
+
+use Illuminate\Foundation\Bus\Dispatchable;
+use Illuminate\Foundation\Bus\DispatchesJobs;
+use Illuminate\Support\Facades\Bus;
+
+class DispatchableJobClass
+{
+    use Dispatchable;
+}
+
+class DispatchesJobsClass
+{
+    use DispatchesJobs;
+}
+
+class Kernel extends \Illuminate\Foundation\Http\Kernel
+{
+    protected $middlewareAliases = [];
+}
+
+Bus::dispatchSync(fn () => null);
+DispatchableJobClass::dispatchSync(fn () => null);
+DispatchesJobsClass::dispatchSync(fn () => null);
+dispatch_sync(fn () => null);
+
+?>

tests/Sets/Laravel100/Laravel100Test.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RectorLaravel\Tests\Sets\Laravel100;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class Laravel100Test extends AbstractRectorTestCase
+{
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    /**
+     * @test
+     */
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Sets/Laravel100/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../../../../config/sets/laravel100.php');
+};