Fix redundant default arguments in Laravel 9 set, add tests for the Laravel 9 set. (#221)

Author: GeniJaho

config/sets/laravel90.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Arguments\Rector\ClassMethod\ArgumentAdderRector;
-use Rector\Arguments\ValueObject\ArgumentAdder;
+use Rector\Arguments\ValueObject\ArgumentAdderWithoutDefaultValue;
 use Rector\Config\RectorConfig;
 use Rector\Renaming\Rector\MethodCall\RenameMethodRector;
 use Rector\Renaming\ValueObject\MethodCallRename;
@@ -19,29 +19,27 @@
 
     // https://github.com/laravel/framework/commit/8f9ddea4481717943ed4ecff96d86b703c81a87d
     $rectorConfig
-        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdder(
+        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdderWithoutDefaultValue(
             'Illuminate\Contracts\Foundation\Application',
             'storagePath',
             0,
             'path',
-            ''
         ),
         ]);
 
     // https://github.com/laravel/framework/commit/e6c8aaea886d35cc55bd3469f1a95ad56d53e474
     $rectorConfig
-        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdder(
+        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdderWithoutDefaultValue(
             'Illuminate\Foundation\Application',
             'langPath',
             0,
             'path',
-            ''
         ),
         ]);
 
     // https://github.com/laravel/framework/commit/e095ac0e928b5620f33c9b60816fde5ece867d32
     $rectorConfig
-        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdder(
+        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdderWithoutDefaultValue(
             'Illuminate\Database\Eloquent\Model',
             'touch',
             0,
@@ -51,7 +49,7 @@
 
     // https://github.com/laravel/framework/commit/6daecf43dd931dc503e410645ff4a7d611e3371f
     $rectorConfig
-        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdder(
+        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdderWithoutDefaultValue(
             'Illuminate\Queue\Failed\FailedJobProviderInterface',
             'flush',
             0,

stubs/Illuminate/Foundation/Application.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Foundation;
+
+if (class_exists('Illuminate\Foundation\Application')) {
+    return;
+}
+
+class Application
+{
+}

stubs/Illuminate/Foundation/Exceptions/Handler.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Foundation\Exceptions;
+
+if (class_exists('Illuminate\Foundation\Exceptions\Handler')) {
+    return;
+}
+
+class Handler
+{
+}

stubs/Illuminate/Mail/MailManager.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Mail;
+
+if (class_exists('Illuminate\Mail\MailManager')) {
+    return;
+}
+
+class MailManager
+{
+}

stubs/Illuminate/Mail/Mailable.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Mail;
+
+if (class_exists('Illuminate\Mail\Mailable')) {
+    return;
+}
+
+class Mailable
+{
+}

stubs/Illuminate/Mail/Mailer.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Mail;
+
+if (class_exists('Illuminate\Mail\Mailer')) {
+    return;
+}
+
+class Mailer
+{
+}

stubs/Illuminate/Mail/Message.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Mail;
+
+if (class_exists('Illuminate\Mail\Message')) {
+    return;
+}
+
+class Message
+{
+}

stubs/Illuminate/Notifications/Messages/MailMessage.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Notifications\Messages;
+
+if (class_exists('Illuminate\Notifications\Messages\MailMessage')) {
+    return;
+}
+
+class MailMessage
+{
+}

stubs/Illuminate/Queue/Failed/FailedJobProviderInterface.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Queue\Failed;
+
+if (class_exists('Illuminate\Queue\Failed\FailedJobProviderInterface')) {
+    return;
+}
+
+interface FailedJobProviderInterface
+{
+}

stubs/Illuminate/Support/Enumerable.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Illuminate\Support;
+
+if (class_exists('Illuminate\Support\Enumerable')) {
+    return;
+}
+
+interface Enumerable
+{
+}