Skip to content

add 0x3D WriteMemoryByAddress#85

Merged
driftregion merged 2 commits intodriftregion:mainfrom
frickly-systems:read_memory_by_address
Sep 4, 2025
Merged

add 0x3D WriteMemoryByAddress#85
driftregion merged 2 commits intodriftregion:mainfrom
frickly-systems:read_memory_by_address

Conversation

@f43i4n
Copy link
Contributor

@f43i4n f43i4n commented Sep 2, 2025

The following PR should add functionality to support 0x3D WriteMemoryByAddress

  • add Handler for 0x3D
  • add event and args for WriteMemoryByAddress
  • add happy path test using the examples from the standard

Signed-off-by: Fabian Gajek <fabian.gajek@frickly.systems>
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.90%. Comparing base (a147e9a) to head (792d230).

Files with missing lines Patch % Lines
iso14229.c 66.66% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #85       +/-   ##
===========================================
- Coverage   56.68%   30.90%   -25.78%     
===========================================
  Files           6        2        -4     
  Lines        2934     2084      -850     
  Branches      595      425      -170     
===========================================
- Hits         1663      644     -1019     
- Misses        905     1305      +400     
+ Partials      366      135      -231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@driftregion
Copy link
Owner

looks good. Feel free to ignore the failing codecov check -- the coverage from fuzzing is not yet merged into main. would you like to add yourself to AUTHORS.txt?

Signed-off-by: Fabian Gajek <fabian.gajek@frickly.systems>
@f43i4n
Copy link
Contributor Author

f43i4n commented Sep 4, 2025

looks good. Feel free to ignore the failing codecov check -- the coverage from fuzzing is not yet merged into main. would you like to add yourself to AUTHORS.txt?

I added myself 😄

@driftregion driftregion merged commit 1e849e9 into driftregion:main Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants